Uh you lost me there.
They aren't even looseley based arround the chinese elements which are Fire, Water, Earth, Wood and Gold/Metal.
Damn now i want METAL ELVES who only use axes and have glorious hair.
All elves share these traits:
Fey ancestry
Darkvision 60ft
ASI +2 Dex
Fire elves:
Fire is explosive and wild/willfull in nature so Cha it is.
ASI +1 to Cha
Fire elf weapon training: Sabres, Daggers, Throwing knives/darts/javelins, Whips.
Tempered constitution: Fire resistance
You know one fire based cantrip of your choice from the Wizard, Cleric or Sorcerrer spell list.
Aquatic elves:
Their bodies suffer the pressure and cold of water but are also adapted to swim constantly so either Str or Con works but lets go with Str since in chinese myths water is associated with strenght.
ASI +1 Str
Tempered constitution: Frost resistance
Aquatic: Water breathing and swim speed equal to land movement speed.
Aquatic elf weapon training: Daggers, Shortswords, Spears, Tridents, Nets.
Now for earth we can make surface dwelling elves who use mould earth to live in various terrains and since it's the most practical magic in DnD (seriously given enough time with mould earth you can build a fortress with minimal expenses within a few months).
We could just call them magic humans at this point but eh.. Lets go with mountain elves.
Mountain elves:
ASI + 1 Con
Mountain elf weapon training: Quarterstaff, Spear, Sling, Javelin, Warhammer, Halberd.
Know the mould earth cantrip.
Now what resistance or benefit could they gain?
Since earth is associated with endurance and vitality lets go with gaining one extra death save per long rest and recovering from an exhaustion level extreemley easily like 1-2 levels per shor rest (which would make berseker barbarian viable).
Cont.